[201911] [Mellanox] Read PSU fan max/min speed per PSU #8728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New PSU could install different type of fan, so fan max/min speed should be read per PSU The existing implementation read PSU max/min fan speed from a common file, change it to read from per PSU file Manual test Conflicts: platform/mellanox/mlnx-platform-api/sonic_platform/fan.py
|
/azp run |
|
Commenter does not have sufficient privileges for PR 8728 in repo Azure/sonic-buildimage |
5 tasks
keboliu
approved these changes
Sep 10, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
liat-grozovik
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
seems the failure is not related to this PR. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #8563 to 201911
Why I did it
New PSU could install different type of fan, so fan max/min speed should be read per PSU
How I did it
The existing implementation read PSU max/min fan speed from a common file, change it to read from per PSU file
How to verify it
Manual test
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)